Skip to content

Conversation

@sumit-anantwar
Copy link


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the Go-v2 This issue relates to the AWS SDK for Go V2 label Oct 26, 2024
@Laren-AWS
Copy link
Contributor

Thanks for your contribution!

However, I encountered some issues:

  • My attempts to install and compile portaudio for Windows did not work. It looks like the project versions are too old to convert properly, and I'm concerned customers would encounter this issue as well when trying to run this example. I recommend either finding a newer library for audio or simplifying the example to work from prerecorded audio files instead of including the microphone as part of the example.
  • Your example doesn't follow all of our current standards such as loading default AWS credentials, handling errors, and including unit and/or integration tests.

I'm closing this PR for now, but feel free to make the above changes and reopen, thanks!

@Laren-AWS Laren-AWS closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Go-v2 This issue relates to the AWS SDK for Go V2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants