Weathertop: Fix batchStorage not being a number. #7034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Tools
Contributor
|
It would make more sense to put this check on ingest via targets.ts to make sure it's an Integer in the configuration file itself, instead of adding it later down in the stack. |
DavidSouther
force-pushed
the
bug/plugin_stack.ts
branch
4 times, most recently
from
fcfe092 to
9110a17
Compare
ford-at-aws
approved these changes
Nov 12, 2024
meyertst-aws
approved these changes
Nov 12, 2024
meyertst-aws
force-pushed
the
bug/plugin_stack.ts
branch
from
9110a17 to
43d76c7
Compare
meyertst-aws
added
On Call Review complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.