Java: Add basic SaaS code samples for CloudFront #7501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Java-v2
Dogiogi25
changed the title
ogiderek
force-pushed
the
saas-doc-updates
branch
2 times, most recently
from
2da9136 to
ef2b492
Compare
Contributor
|
I am reviewing this code |
scmacdon
reviewed
Jul 4, 2025
...2/example_code/cloudfront/src/main/java/com/example/cloudfront/CreateDistributionTenant.java
Show resolved
Hide resolved
scmacdon
reviewed
Jul 4, 2025
...mple_code/cloudfront/src/main/java/com/example/cloudfront/CreateMultiTenantDistribution.java
Show resolved
Hide resolved
Author
|
Regarding the main(), I was following our existing patterns here + writing them as utility-focused classes so I thought it wouldn't be necessary: https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/java_cloudfront_code_examples.html I can add if absolutely necessary, but I don't think it's necessary for this style of code snippet + scenario |
ogiderek
force-pushed
the
saas-doc-updates
branch
from
3c4b0e2 to
8d22239
Compare
Author
|
And thanks, a new version of the commit has been pushed with the updated import list |
tkhill-AWS
reviewed
Jul 7, 2025
Collaborator
tkhill-AWS
left a comment
tkhill-AWS
left a comment
There was a problem hiding this comment.
Integration test is needed.
tkhill-AWS
reviewed
Jul 7, 2025
...2/example_code/cloudfront/src/main/java/com/example/cloudfront/CreateDistributionTenant.java
Show resolved
Hide resolved
tkhill-AWS
reviewed
Jul 7, 2025
...mple_code/cloudfront/src/main/java/com/example/cloudfront/CreateMultiTenantDistribution.java
Show resolved
Hide resolved
ogiderek
force-pushed
the
saas-doc-updates
branch
5 times, most recently
from
2fe5ccf to
7f06ce4
Compare
ogiderek
force-pushed
the
saas-doc-updates
branch
from
7f06ce4 to
111becc
Compare
Author
Thanks, added in current commit, lmk if printouts or results are necessary to be shared somewhere |
scmacdon
approved these changes
Jul 21, 2025
Contributor
scmacdon
left a comment
scmacdon
left a comment
There was a problem hiding this comment.
Cloud Desktop build and code looks good, I approve this.
scmacdon
added
On Call Review needed
brmur
added
Feature Scenario
brmur
added
On Call Review needed
Contributor
|
@scmacdon WRITEME is failing with known error. Can you please address? |
scmacdon
approved these changes
Jul 30, 2025
Contributor
scmacdon
left a comment
scmacdon
left a comment
There was a problem hiding this comment.
This PE builds the CD and code is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds code samples for new SaaS APIs in CloudFront for Javav2 SDK
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.