PHP: [Bug#7535] : Fix message and logic #7537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beqqrry-aws
added
Bug
beqqrry-aws
approved these changes
Jul 28, 2025
beqqrry-aws
changed the title
Contributor
Author
|
@beqqrry-aws how we can close this ? Do I need to join any call or will it be internal ? |
scmacdon
added
On Call Review complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug#7535
This pull request is for
$checkis the result of $this->s3client->listObjectsV2(), which returns an array with metadata about the bucket and, if present, a Contents key containing the objects.count($check)will always be at least 1 (because it's an array with metadata), even if the bucket is empty.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.