Skip to content

Update method name to describe a Get request #7558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2025
Merged

Update method name to describe a Get request #7558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1598e26
Update method name to describe a Get request
tkhill-AWS Aug 26, 2025
be3b4cc
Merge branch 'main' into s3-method-name
beqqrry-aws Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions javav2/example_code/s3/src/main/java/com/example/s3/GeneratePresignedGetUrlAndRetrieve.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public static void main(String[] args) {
String presignedUrlString = presign.createPresignedGetUrl(bucketName, keyName);
presign.useHttpUrlConnectionToGet(presignedUrlString);
presign.useHttpClientToGet(presignedUrlString);
presign.useSdkHttpClientToPut(presignedUrlString);
presign.useSdkHttpClientToGet(presignedUrlString);
} finally {
PresignUrlUtils.deleteObject(bucketName, keyName, s3Client);
PresignUrlUtils.deleteBucket(bucketName, s3Client);
Expand Down Expand Up @@ -142,7 +142,7 @@ public byte[] useHttpClientToGet(String presignedUrlString) {

// snippet-start:[presigned.java2.generatepresignedgeturlandretrieve.sdkhttpclient]
/* Use the AWS SDK for Java SdkHttpClient class to do the download. */
public byte[] useSdkHttpClientToPut(String presignedUrlString) {
public byte[] useSdkHttpClientToGet(String presignedUrlString) {

ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream(); // Capture the response body to a byte array.
try {
Expand Down
2 changes: 1 addition & 1 deletion ...example_code/s3/src/test/java/com/example/s3/presignurl/GeneratePresignedGetUrlTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ void testUsingJdkHttpClient() {
GeneratePresignedGetUrlAndRetrieve presignInstanceUnderTest = new GeneratePresignedGetUrlAndRetrieve();
final String presignedUrlString = presignInstanceUnderTest.createPresignedGetUrl(BUCKET_NAME, KEY_NAME);

final byte[] bytes = presignInstanceUnderTest.useSdkHttpClientToPut(presignedUrlString);
final byte[] bytes = presignInstanceUnderTest.useSdkHttpClientToGet(presignedUrlString);
Assertions.assertTrue(bytes.length > 0);
}
}
Loading