Skip to content

fix: hide api key when provider is excluded from export #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ymkiux merged 5 commits into from
Mar 17, 2026
Merged

fix: hide api key when provider is excluded from export #423

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a8dedd
fix: hide api key for excluded providers
Mar 17, 2026
fe2d711
fix: separate export exclusion from error cooldown
Mar 17, 2026
5b18a0d
fix: collapse edit form grid without api key
Mar 17, 2026
79f25df
fix: show api key placeholder for excluded providers
Mar 17, 2026
9974ae0
fix: keep api key editable for excluded providers
Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions web/src/pages/providers/components/custom-config-step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,36 +225,36 @@ export function CustomConfigStep() {
<h3 className="text-lg font-semibold text-text-primary border-b border-border pb-2">
{t('provider.errorCooldownTitle')}
</h3>
<div className="space-y-4">
<div className="flex items-center justify-between p-4 bg-card border border-border rounded-xl">
<div className="pr-4">
<div className="text-sm font-medium text-foreground">
{t('provider.disableErrorCooldown')}
</div>
<p className="text-xs text-muted-foreground mt-1">
{t('provider.disableErrorCooldownDesc')}
</p>
<div className="flex items-center justify-between p-4 bg-card border border-border rounded-xl">
<div className="pr-4">
<div className="text-sm font-medium text-foreground">
{t('provider.disableErrorCooldown')}
</div>
<Switch
checked={!!formData.disableErrorCooldown}
onCheckedChange={(checked) => updateFormData({ disableErrorCooldown: checked })}
/>
<p className="text-xs text-muted-foreground mt-1">
{t('provider.disableErrorCooldownDesc')}
</p>
</div>
<Switch
checked={!!formData.disableErrorCooldown}
onCheckedChange={(checked) => updateFormData({ disableErrorCooldown: checked })}
/>
</div>
</div>

<div className="flex items-center justify-between p-4 bg-card border border-border rounded-xl">
<div className="pr-4">
<div className="text-sm font-medium text-foreground">
{t('provider.excludeFromExport')}
</div>
<p className="text-xs text-muted-foreground mt-1">
{t('provider.excludeFromExportDesc')}
</p>
</div>
<Switch
checked={!!formData.excludeFromExport}
onCheckedChange={(checked) => updateFormData({ excludeFromExport: checked })}
/>
<div className="space-y-6">
<h3 className="text-lg font-semibold text-text-primary border-b border-border pb-2">
{t('provider.excludeFromExport')}
</h3>
<div className="flex items-center justify-between p-4 bg-card border border-border rounded-xl">
<div className="pr-4">
<p className="text-xs text-muted-foreground mt-1">
{t('provider.excludeFromExportDesc')}
</p>
</div>
<Switch
checked={!!formData.excludeFromExport}
onCheckedChange={(checked) => updateFormData({ excludeFromExport: checked })}
/>
</div>
</div>

Expand Down
49 changes: 26 additions & 23 deletions web/src/pages/providers/components/provider-edit-flow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ export function ProviderEditFlow({ provider, onClose }: ProviderEditFlowProps) {
};

const [showApiKey, setShowApiKey] = useState(false);
const shouldShowApiKeyField = !provider.excludeFromExport;
const [formData, setFormData] = useState<EditFormData>({
name: provider.name,
baseURL: provider.config?.custom?.baseURL || '',
Expand Down Expand Up @@ -658,31 +659,33 @@ export function ProviderEditFlow({ provider, onClose }: ProviderEditFlowProps) {
</p>
</div>

<div>
<label className="text-sm font-medium text-foreground block mb-2">
<div className="flex items-center gap-2">
<Key size={14} />
<span>{t('provider.apiKeyEdit')}</span>
{shouldShowApiKeyField && (
<div>
<label className="text-sm font-medium text-foreground block mb-2">
<div className="flex items-center gap-2">
<Key size={14} />
<span>{t('provider.apiKeyEdit')}</span>
</div>
</label>
<div className="relative">
<Input
type={showApiKey ? 'text' : 'password'}
value={formData.apiKey}
onChange={(e) => setFormData((prev) => ({ ...prev, apiKey: e.target.value }))}
placeholder={t('provider.keyPlaceholder')}
className="w-full pr-10"
/>
<button
type="button"
onClick={() => setShowApiKey(!showApiKey)}
className="absolute right-2 top-1/2 -translate-y-1/2 text-muted-foreground hover:text-foreground transition-colors"
tabIndex={-1}
>
{showApiKey ? <EyeOff className="h-4 w-4" /> : <Eye className="h-4 w-4" />}
</button>
</div>
</label>
<div className="relative">
<Input
type={showApiKey ? 'text' : 'password'}
value={formData.apiKey}
onChange={(e) => setFormData((prev) => ({ ...prev, apiKey: e.target.value }))}
placeholder={t('provider.keyPlaceholder')}
className="w-full pr-10"
/>
<button
type="button"
onClick={() => setShowApiKey(!showApiKey)}
className="absolute right-2 top-1/2 -translate-y-1/2 text-muted-foreground hover:text-foreground transition-colors"
tabIndex={-1}
>
{showApiKey ? <EyeOff className="h-4 w-4" /> : <Eye className="h-4 w-4" />}
</button>
</div>
</div>
)}
</div>
</div>
</div>
Expand Down
Loading