fix: address PR #140 review feedback for release workflow#141
Merged
scottschreckengaust merged 1 commit intomainfrom Mar 23, 2026
Merged
fix: address PR #140 review feedback for release workflow#141scottschreckengaust merged 1 commit intomainfrom
scottschreckengaust merged 1 commit intomainfrom
Conversation
Use ::error:: instead of ::warning:: for fatal conditions, add actionable remediation message for unchanged changelog, use array-based label args for safe shell expansion, and fix PR title to use $TAG instead of $BRANCH.
scottschreckengaust
requested review from
a team,
harmjeff,
raj-jain-aws and
spraja08
Kalindi-Dev
approved these changes
Mar 23, 2026
Contributor
Kalindi-Dev
left a comment
Kalindi-Dev
left a comment
There was a problem hiding this comment.
LGTM, part of release cycle.
harmjeff
approved these changes
Mar 23, 2026
Contributor
harmjeff
left a comment
harmjeff
left a comment
There was a problem hiding this comment.
Appropriate error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the 5 review suggestions from copilot-pull-request-reviewer on PR #140, as noted by @Kalindi-Dev for a subsequent release.
::error::instead of::warning::for fatal "nothing to release" condition (line 73)::error::instead of::warning::for fatal "branch already exists" condition (line 112)::error::with actionable remediation message for unchanged changelog (line 121)LABEL_FLAGwith array-basedlabel_argsfor safe shell expansion (lines 129-134)$TAGinstead of$BRANCHfor consistency with commit message (line 138)Test plan
::error::annotation appears::error::annotation appears::error::messagev0.3.0) not branch prefix (release/v0.3.0)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.