Skip to content

Commit c62e231

Browse files
authored
chore: add shellcheck commit to blame ignored revs (#2373)
Add to the revs ignored for blame. Fix two issues introduced in that PR (ironic...)
1 parent 8f395aa commit c62e231

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

.git-blame-ignore-revs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,5 @@
22
6014c4e6872a23f82ca295afa93b033207042876
33
# Addressed space errors
44
bde408b340d992aad39e13de1aaf929f358f4338
5+
# Shellcheck fixes
6+
8f395aaa776ff7bbfe52188a6164b1a10875e36d

templates/al2023/provisioners/install-nvidia-driver.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ function is-isolated-partition() {
2222

2323
function rpm_install() {
2424
local RPMS
25-
mapfile -t RPMS <<< "$@"
25+
read -ra RPMS <<< "$@"
2626
echo "Pulling and installing local rpms from s3 bucket"
2727
for RPM in "${RPMS[@]}"; do
2828
aws s3 cp --region ${BINARY_BUCKET_REGION} s3://${BINARY_BUCKET_NAME}/rpms/${RPM} ${WORKING_DIR}/${RPM}

templates/test/cases/cloud-provider-config.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ KUBELET_CONFIG_FILE="/etc/kubernetes/kubelet/kubelet-config.json"
1010
function fail() {
1111
echo "❌ Test Failed:" "$@"
1212
echo "Kubelet systemd units:"
13-
find $KUBELET_UNIT_DIR -type f -print0 | xargs cat
13+
find $KUBELET_UNIT_DIR -type f -print0 | xargs -0 cat
1414
echo "Kubelet config file:"
1515
cat $KUBELET_CONFIG_FILE | jq '.'
1616
exit 1

0 commit comments

Comments
 (0)