feat(nodeadm): add console logging support to nodeadm#2620
Merged
fletcherw merged 1 commit intoawslabs:mainfrom Feb 23, 2026
Merged
feat(nodeadm): add console logging support to nodeadm#2620fletcherw merged 1 commit intoawslabs:mainfrom
fletcherw merged 1 commit intoawslabs:mainfrom
Conversation
Contributor
|
Hello! This is an interesting change, but I'm not sure we want to enable this by default. Can you say more about your issues with "This helps troubleshoot node not joining cluster issues and the access to node is limited." Do you have nodes where SSM or SSH access are not possible? |
fletcherw
reviewed
Feb 19, 2026
Contributor
fletcherw
left a comment
There was a problem hiding this comment.
After further discussion, I think we're actually good to do this via systemd, that way the log output sent to the console is timestamped and has the systemd unit name like so:
[ 7.468759] cloud-init[2247]: Cloud-init v. 22.2.2 running 'modules:config' at Thu, 19 Feb 2026 20:17:38 +0000. Up 7.41 seconds.
[ 8.005622] cloud-init[2260]: Cloud-init v. 22.2.2 running 'modules:final' at Thu, 19 Feb 2026 20:17:39 +0000. Up 7.93 seconds.
[ 8.065212] cloud-init[2260]: Cloud-init v. 22.2.2 finished at Thu, 19 Feb 2026 20:17:39 +0000. Datasource DataSourceEc2. Up 8.05 seconds
[ 8.181199] nodeadm[2261]: info init/init.go:55 Checking user is root..
[ 8.182677] nodeadm[2261]: info init/init.go:65 Loading configuration.. {"configSource": ["imds://user-data", "file:///etc/eks/nodeadm.d/"], "configCache": "/run/eks/nodeadm/config.json"}
[ 8.188546] nodeadm[2261]: warn configprovider/chain.go:30 Encountered error in config provider {"error": "no config found in directory"}
[ 8.190862] nodeadm[2261]: info init/init.go:75 Setting up nodeadm environment aspect..
No need to modify the nodeadm logger code.
templates/al2023/runtime/rootfs/etc/systemd/system/nodeadm-boot-hook.service
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the suggestion. I've updated the PR. Please help review it. |
This helps troubleshoot node not joining cluster issues when the access to node is limited.
fletcherw
approved these changes
Feb 23, 2026
Contributor
|
gosec failure is a false positive, proceeding to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
This PR adds a global flag
--consoleto enable sending nodeadm logs to the node console. This helps troubleshoot node not joining cluster issues and the access to node is limited. The global flag--consoledefaults to false to be backward compatible.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.