chore: suppress G602 for CPU to reserve#2640
Merged
fletcherw merged 1 commit intoawslabs:mainfrom Feb 27, 2026
Merged
Conversation
mselim00
added
the
changelog/exclude
Contributor
|
I think this is possibly a bug in gosec, assuming that a |
fletcherw
approved these changes
Feb 27, 2026
Contributor
Author
|
I think you're probably right, I just saw securego/gosec#1525 and securego/gosec#1531 - but I don't think the latter would fix this this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This array index is flagged because there's no implicit guarantee that
i + 1exists incpuRangesifiis based on the length ofcpuPercentageReservedForRanges. This is informally guaranteed though by the nature of the function, so this just adds a suppression until this can be refactored in a way that avoids this.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.