Conversation
|
/ci |
|
@fletcherw roger that! I've dispatched a workflow. 👍 |
|
@fletcherw the workflow that you requested has completed. 🎉
|
|
/ci |
|
@mselim00 the workflow that you requested has completed. 🎉
|
|
/ci |
|
@fletcherw roger that! I've dispatched a workflow. 👍 |
|
@fletcherw the workflow that you requested has completed. 🎉
|
There was a problem hiding this comment.
We may want to keep the docs for AL2 for now.
| hack/lint-space-errors.sh | ||
|
|
||
| .PHONY: test | ||
| test: ## run the test-harness |
There was a problem hiding this comment.
Did this only test AL2? It seem so but I want to check.
|
|
||
| BUILD_TARGETS := build k8s validate | ||
|
|
||
| ifneq ($(filter $(BUILD_TARGETS),$(MAKECMDGOALS)),) |
There was a problem hiding this comment.
Instead of validating the input, would it be better/more-consistent if we set defaults?
There was a problem hiding this comment.
I worry the defaults won't be updated, given that we left our latest versions as 1.28 for a while.
Youssef-Beltagy
left a comment
There was a problem hiding this comment.
LGTM but I left some changes that I think would be nice to take up.
| return new_doc | ||
|
|
||
| for template in ['al2', 'al2023']: | ||
| for template in ['al2023']: |
There was a problem hiding this comment.
We may want to keep the AL2 docs up until AL2 is deprecated by EC2 in mid of this year.
There was a problem hiding this comment.
updated, deleting this here but leaving the al2 doc for now.
|
/ci |
|
@fletcherw roger that! I've dispatched a workflow. 👍 |
|
@fletcherw the workflow that you requested has completed. 🎉
|
AL2 support has been EOL for several months, remove it from the repo.
|
@fletcherw hey I am from AWS DLAMI team. Our eks AL2 pipelines failed this week because your team remove the support for AL2. |
AL2 support has been EOL for several months, remove it from the repo.