fix(config): correct maxLeaseRenewalThreads validation to match error message#1703
Open
abhu85 wants to merge 1 commit intoawslabs:masterfrom
Open
fix(config): correct maxLeaseRenewalThreads validation to match error message#1703abhu85 wants to merge 1 commit intoawslabs:masterfrom
abhu85 wants to merge 1 commit intoawslabs:masterfrom
Conversation
… message The validation used `maxLeaseRenewalThreads > 2` but the error message stated "must be greater than or equal to 2". This caused values of exactly 2 to be rejected even though the error message indicated 2 should be valid. Changes: - Fix validation from `> 2` to `>= 2` to match error message - Update Javadoc @throws description to accurately describe the behavior Fixes awslabs#207 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Abhishek Chauhan <60182103+abhu85@users.noreply.github.com>
Author
|
Friendly ping for review. This is a minimal 2-line fix for the off-by-one validation bug in #207 - the condition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix off-by-one validation bug in
withMaxLeaseRenewalThreads()method where the validation condition did not match the error message.Problem: The validation used
maxLeaseRenewalThreads > 2but the error message stated "must be greater than or equal to 2". This caused values of exactly 2 to be rejected even though the error message indicated 2 should be valid.Fix:
> 2to>= 2to match the error message@throwsdescription from "if maxLeaseRenewalThreads is <= 0" to "if maxLeaseRenewalThreads is less than 2" to accurately describe the actual behaviorTest plan
Changes
Fixes #207
Generated with Claude Code