Disable sanitizer recovery mode by default in CMake#1233
Open
bjosv wants to merge 1 commit intoawslabs:mainfrom
Open
Disable sanitizer recovery mode by default in CMake#1233bjosv wants to merge 1 commit intoawslabs:mainfrom
bjosv wants to merge 1 commit intoawslabs:mainfrom
Conversation
Since we want to find sanitizer issues when running with `-DENABLE_SANITIZERS=ON` we disable the recovery mode by default. By adding the compile flag `-fno-sanitize-recover=all` a testcase will now terminate instead of just print out any recoverable ASAN/UBSAN issue. Issues are visible in local test runs and in CI. The following CMake option is added and can be used by projects that has known issues: -DENABLE_SANITIZER_RECOVERY=ON Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we want to find sanitizer issues when running with
-DENABLE_SANITIZERS=ONwe disable the recovery mode by default. By adding the compile flag-fno-sanitize-recover=alla testcase will now terminate instead of just print out any recoverable ASAN/UBSAN issue.Issues are more visible in test runs/CI due to an emitted exit code instead of an error log.
The following CMake option is added and can be used by projects that has known issues:
-DENABLE_SANITIZER_RECOVERY=ONBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.