Fix for ByteBuffer Bug #964
Open
+196
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-java-v2#6666
Description of changes:
When allocating GetDirectByteBuffer takes values > Integer.MAX_VALUE, JNI returns a null buffer due to an Illegal Argument exception.
Resolving this issue by allocating and reading data into smaller buffers until part size is reached to perform the UploadPart operation instead of allocating one big buffer.
Adding a test to ensure this works correctly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.