Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the ESDK decrypt.md specification document by removing version history, implementation tables, and RFC2119 conventions (moving the latter to the top-level README.md), and rewording specification language to be more explicit with RFC2119 keywords (MUST/SHOULD) and to use clearer subject references (e.g., "the Decrypt operation" instead of "this operation").
Changes:
- Removed changelog, implementation table, and RFC2119 conventions section from
decrypt.md, relocating the RFC2119 reference toREADME.md. - Rewrote input/output sections and operational steps to use more explicit RFC2119 language and consistent naming.
- Replaced ambiguous "this operation" references with specific subjects like "the Decrypt operation" or "the streamed Decrypt operation".
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
client-apis/decrypt.md |
Removed version/changelog/implementations sections, rewrote input/output/steps with explicit RFC2119 keywords and clearer subjects |
README.md |
Added top-level RFC2119 conventions section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Check any applicable: