Skip to content

Conversation

jlizen
Copy link
Contributor

@jlizen jlizen commented Aug 26, 2025

📬 Issue #, if available:
n/a

✍️ Description of changes:
Preparing releases for new changes to various crates.

Breaking changes

I was considering #955 as a semver breaking change since it is changing the serialized output type of a field. It seems like it would mostly break tests since customers are not really serializing request structs in the wild, rather they are deserializing. But test breakage is still breakage.

And since that is a breaking change, lambda_http would be breaking by bumping its dependency.

Glad to revise this if other maintainers feel differently.

Not bumping patch versions on path dependencies

Meanwhile, I intentionally did not bump path dependency versions for non-breaking (patch version) changes. Since, all that really accomplishes is break somebody that for some odd reason wants to pin back to an older version and/or is using an older mirror of the crates.io index or something.

Anyway cargo resolution will use the newest version for any consumers that aren't pinning it. So, I don't see much benefit.

Generally you only see larger repos like tokio bumping patch versions of patch dependencies when they want to explicitly use a new API.

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jlizen jlizen changed the title chore: prepare [email protected], [email protected], lambda_runtime_api_client chore: prepare [email protected], [email protected], [email protected], [email protected] Aug 26, 2025
@jlizen jlizen requested a review from bnusunny August 26, 2025 21:20
Copy link
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlizen jlizen merged commit 7ac2274 into awslabs:main Aug 27, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants