-
Notifications
You must be signed in to change notification settings - Fork 8
Release: AWS SDK for Python v0.1.1 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ## v0.1.1 | ||
|
|
||
| ### API Changes | ||
| * New stop reason (`MODEL_CONTEXT_WINDOW_EXCEEDED`) for Converse and ConverseStream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit; we won't be getting these kinds of updates from the normal model releases. We should consider if we want to keep this to using the "official" service team release notes rather than writing our own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "official" service team release note is New stop reason for Converse and ConverseStream. I added the MODEL_CONTEXT_WINDOW_EXCEEDED part to provide clarity. I'll update to use the exact service note though
Reference: https://github.com/boto/botocore/blob/develop/CHANGELOG.rst#L252
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in d0f4286
| * **Updated**: `smithy_http[awscrt]` from `~=0.1.0` to `~=0.2.0`. | ||
|
|
||
| ### Breaking | ||
| - Removed unused `serialize.py` and `deserialize.py` modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these being surfaced publicly through an __all__ or interceptors? I don't actually recall but curious about the scope of this call out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the modules exist in v0.1.0 but aren't used by anything. I mainly called it out since someone could technically be doing import aws_sdk_bedrock_runtime.serialize or import aws_sdk_bedrock_runtime.deserialize. The probability of that though is near 0. I have some context in the PR summary about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's fine. I'm asking at a higher level about our public contract with this. It's implying we may have been expecting someone to do this.
We handle these cases in boto3 because we have a very fuzzy contract. We don't want to carry that forward in this product. It should be extremely clear what is a public interface and then we treat everything else as private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, I think you saying these should have originally been _serialize.py and _deserialize.py so it's clear to customers these are internal only and shouldn't be used directly. I agree
Important
This PR is reliant on the packages in smithy-lang/smithy-python#580 being released to PyPI.
Summary
This PR creates v0.1.1 of
aws-sdk-bedrock-runtimeandaws-sdk-pythonusing the latest Smithy Python code generator, core packages, and bedrock runtime service model.Why patch and not minor version bump?
Removing the
serialize.pyanddeserialize.pymodules is technically breaking, however, these modules aren't used by any client code starting in v0.1.0. These modules should have been cleaned up but were missed in the previous release. There is no valid reason for users to be importing these modules directly. Additionally, I searched through GitHub and found 0 matches foraws_sdk_bedrock_runtime.serializeandaws_sdk_bedrock_runtime.deserialize. Keeping this a patch bump reduces the friction for customers adopting this change since most will receive the update automatically.Testing
make build-pyso packages are build indistcd clients/aws-sdk-bedrock-runtimeuv venvand. .venv/bin/activateuv buildaws-sdk-bedrock-runtime==0.1.1using the packages build in previous steps. See example belowBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.