Conversation
|
Hi, thanks for introducing these changes. We have no overall concerns. Do you have an idea for further test cases for example to validate your use case of having custom configurations? If nothing comes to mind, we are happy to merge as is, or we can do this as a follow-up task. |
|
I still think this is valuable, but in my own code I ended up using Lift's native scala json library. I'd actually recommend migrating this code over to that library for a few reasons:
For example, here's a serialized histogram And here's how you deserialize it I didn't dive in and go this route because the current Serde design is effected to get the cleanest implementation. So it would take a bit more thought to migrate. |
|
Any plans to merge this? |
I actually took a different approach. writing a serde that did not require juggling java to scala types. If this is still seen as valuable, I can merge it. |
Description of changes:
This PR lifts the private restrictions on the SERDE classes. It also reorganizes the code to a single object/class per file for easier code navigation and discovery.
No functional or dependency changes were made.
My personal motivation for these changes is the ability to have an entirely configuration driven validation class where checks and metrics are defined in a json, yaml, or hocon configuration file.
However, I see it's come up a couple of times. Like the PR for making the AnalysisResult SERDE public and the Extending MetricsRepository Issue #232.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.