This repository was archived by the owner on May 6, 2024. It is now read-only.
Create default SG for Task Run and Service Create#113
Open
senglin wants to merge 1 commit intoawslabs:masterfrom
Open
Create default SG for Task Run and Service Create#113senglin wants to merge 1 commit intoawslabs:masterfrom
senglin wants to merge 1 commit intoawslabs:masterfrom
Conversation
- Added SetDefaultSecurityGroupID call to check for default security groups for run task and create service. - Run task and create service creates default security group if default security group does not exist. - Similar function in vpc_operation.go is refactored into EC2 client and shared with service_create.go and task_run.go. - Added console logs in EC2 client, service_create.go, task_run.go. - Unit tests for refactored code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fargate-defaultsecurity group. For fresh AWS accounts, there is no such SG. This results in anilbeing returned. The CLI continues down this path to register the task/service with the SG, resulting in the following error messagefargate-defaultis available, select it and remove it.Description of changes:
SetDefaultSecurityGroupID()call to check for default security groups for run task andcreate service.
security group does not exist.
vpc_operation.gois refactored into EC2 client andshared with
service_create.goandtask_run.go.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.