-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Remove unsupported 'version' parameter from FastMCP initialization #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Remove unsupported 'version' parameter from FastMCP initialization #1907
Conversation
Remove version parameter that causes TypeError in MCP SDK 1.12.3+ Refactor FastMCP initialization to use standard pattern Extract instructions and dependencies as constants Add create_server() function for better code organization Maintain full compatibility with existing functionality Fixes compatibility issue: TypeError: FastMCP.init() got an unexpected keyword argument 'version' This occurs because the current MCP SDK (1.12.3+) does not support the version parameter in FastMCP initialization.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1907 +/- ##
=======================================
Coverage 90.42% 90.43%
=======================================
Files 852 852
Lines 63393 63396 +3
Branches 10263 10263
=======================================
+ Hits 57326 57329 +3
Misses 3774 3774
Partials 2293 2293 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hashimsharkh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change, there are some validation checks that you need to fix before we merge this change.
Fixed |
This occurs because the current MCP SDK (1.12.3+) does not support the version parameter in FastMCP initialization.
Fixes
Summary
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N)
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.