Skip to content

Conversation

@Huthayfa-Malhas
Copy link

@Huthayfa-Malhas Huthayfa-Malhas commented Dec 8, 2025

  • Remove version parameter that causes TypeError in MCP SDK 1.12.3+
  • Refactor FastMCP initialization to use standard pattern
  • Extract instructions and dependencies as constants
  • Add create_server() function for better code organization
  • Maintain full compatibility with existing functionality
  • Fixes compatibility issue: TypeError: FastMCP.init() got an unexpected keyword argument 'version'

This occurs because the current MCP SDK (1.12.3+) does not support the version parameter in FastMCP initialization.

Fixes

Summary

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Remove version parameter that causes TypeError in MCP SDK 1.12.3+
Refactor FastMCP initialization to use standard pattern
Extract instructions and dependencies as constants
Add create_server() function for better code organization
Maintain full compatibility with existing functionality
Fixes compatibility issue: TypeError: FastMCP.init() got an unexpected keyword argument 'version'

This occurs because the current MCP SDK (1.12.3+) does not support the version parameter in FastMCP initialization.
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.43%. Comparing base (e6c4675) to head (9503eed).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1907   +/-   ##
=======================================
  Coverage   90.42%   90.43%           
=======================================
  Files         852      852           
  Lines       63393    63396    +3     
  Branches    10263    10263           
=======================================
+ Hits        57326    57329    +3     
  Misses       3774     3774           
  Partials     2293     2293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hashimsharkh
hashimsharkh previously approved these changes Dec 9, 2025
Copy link
Contributor

@hashimsharkh hashimsharkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change, there are some validation checks that you need to fix before we merge this change.

@Huthayfa-Malhas
Copy link
Author

Thanks for making the change, there are some validation checks that you need to fix before we merge this change.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

2 participants