Propose allowing unlink for LocalUnopened files #1735
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxbey
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Maxbey
force-pushed
the
bugfix/unlink-local-unopened
branch
from
921fd3e to
8d795db
Compare
Maxbey
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Maxbey
force-pushed
the
bugfix/unlink-local-unopened
branch
from
8d795db to
3793c38
Compare
Maxbey
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Maxbey
force-pushed
the
bugfix/unlink-local-unopened
branch
from
3793c38 to
2ce82d2
Compare
Maxbey
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Maxbey
force-pushed
the
bugfix/unlink-local-unopened
branch
from
2ce82d2 to
38fa041
Compare
Maxbey
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Maxbey
force-pushed
the
bugfix/unlink-local-unopened
branch
from
38fa041 to
2cb1091
Compare
Maxbey
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Files created but never opened (LocalUnopened) have no S3 state and can be unlinked. This prevents files from getting stuck in a state where they cannot be deleted. Signed-off-by: Maksim Beiner <[email protected]>
Maxbey
force-pushed
the
bugfix/unlink-local-unopened
branch
from
2cb1091 to
d907a7e
Compare
Maxbey
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed and why?
We encountered an issue when files became permanently stuck and could not be deleted. This happens when a process crashes (or is killed) between the
mknodandopenFUSE calls.The file is created in
LocalUnopenedstate, but since the process never opens it for writing, there's no way to complete or cancel the write, and unlink becomes blocked if we try to delete the stale file.Previously, unlinking any local file (LocalUnopened, LocalOpen, or PendingRename) was blocked with
unlink on local file not allowed until write is complete. However, files in LocalUnopened state have never been opened for writing, so no S3 upload has started. These files exist only in the local inode tree and can be removed without S3 cleanup.This change separates the handling of LocalUnopened from LocalOpen/PendingRename, allowing unlink to succeed for files that were created but never opened.
Does this change impact existing behavior?
Yes. Previously, attempting to unlink a LocalUnopened file returned an error. Now it succeeds.
Does this change need a changelog entry? Does it require a version change?
Yes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).