feat: add "--log-path" #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. update main.go to make ''--log-path" optional 2. update and fix some errors in README.md 3. add "add_to_bin.sh"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Add "--log-path" to allow users to enable logging the oci-add-hooks for debugging purposes.
Why i send this pull request?
I encountered some errors while using oci-add-hooks, but it didn't have a logging feature. Initially, I had to rely on Google to troubleshoot the errors, but I couldn't find a solution. As a result, I added some logs to oci-add-hooks and discovered that the issue was with hookconfig.json. I think oci-add-hooks should have an optional logging feature, so I submitted this pull request.
Description of changes:
All the modifications have successfully passed the tests and have been validated within a Docker environment.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.