Conversation
f681c1a to
458bf94
Compare
Contributor
|
Hi @qqshfox , thanks for your pull request. Unfortunately, the buckets are already taken so I can't accept. If you'd like, you can change them to snapshots-tool-rds-cn-north-1-official snapshots-tool-rds-cn-northwest-1-official and I'll be happy to merge. Thanks! |
Author
|
These buckets are taken by me. I’ll happy to give them up if you can take these.
Regards,
Hanfei
…________________________________
发件人: mrcoronel <notifications@github.com>
发送时间: 星期四, 二月 13, 2020 19:30
收件人: awslabs/rds-snapshot-tool
抄送: Hanfei Shen; Mention
主题: Re: [awslabs/rds-snapshot-tool] support china regions (#59)
Hi @qqshfox<https://github.com/qqshfox> , thanks for your pull request. Unfortunately, the buckets are already taken so I can't accept. If you'd like, you can change them to snapshots-tool-rds-cn-north-1-official snapshots-tool-rds-cn-northwest-1-official and I'll be happy to merge.
Thanks!
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#59?email_source=notifications&email_token=AADQHVKO5V57C7C5GBJNB33RCUVN3A5CNFSM4KTZ5QV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELUOXGQ#issuecomment-585690010>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AADQHVJCXBLNC5IGSK6V7DLRCUVN3ANCNFSM4KTZ5QVQ>.
|
Contributor
|
I could try to create them again if you delete them from your account. But there is no guarantee someone else will take them |
Author
|
Deleted. |
Contributor
|
Thanks! I've got the buckets in my account now. I'll need to change a few things to upload the lambda code in these buckets, I'll merge the PR once that's ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
AWS::PartitionBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.