Conversation
wrappers/parking_lot/Cargo.toml
Outdated
| @@ -0,0 +1,20 @@ | |||
| [package] | |||
| name = "shuttle-parking_lot" | |||
| version = "0.0.1" | |||
There was a problem hiding this comment.
This should be "0.12.5" right?
There was a problem hiding this comment.
Debatable, I think no.
In my head releasing version mirrors is independent from the code. Thus all wrappers will be pushed as 0.0.1, because this is a releasable non-colliding version for all the packages, meaning we can release it and depend on it without there being any confusion on what version its wrapping. We can also yank a version 0.0.1 that was released (accidentally or not) without any loss. It is thus "safe" to have version 0.0.1. Version "0.12.5" however has a version collision, and publishing it is a final action. It is not "safe" to have version 0.12.5.
Regardless of what we release, I think the crates should live in the repo as 0.0.1s
wrappers/rand_0.8/Cargo.toml
Outdated
| @@ -0,0 +1,22 @@ | |||
| [package] | |||
| name = "shuttle-rand" | |||
| version = "0.0.1" | |||
There was a problem hiding this comment.
Same as the comment on the parking lot version
|
All comments should be addressed |
sarsko
force-pushed
the
parking_lot
branch
4 times, most recently
from
6782e63 to
248d293
Compare
sarsko
force-pushed
the
parking_lot
branch
2 times, most recently
from
a83bc17 to
34899ca
Compare
jorajeev
left a comment
jorajeev
left a comment
There was a problem hiding this comment.
Also add a README similar to what we have for tokio (see https://github.com/awslabs/shuttle/blob/main/wrappers/tokio/README.md )?
sarsko
force-pushed
the
parking_lot
branch
2 times, most recently
from
fbd44aa to
388689a
Compare
2 participants
Adds Shuttle support for the parking_lot library
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.