Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on merge to main we get the following output for benchmarks:
(ref: https://github.com/awslabs/shuttle/actions/runs/20906721819/job/60061562154)
This PR splits up tests and benchmarking, so that benchmarking is only run in PRs, but not on the merge (while tests are ran for both). This means we shouldn't see the error above.
There is a case to be made for adding benchmarking on merge against the previous HEAD, but the results kind of have nowhere to live; if they live in the job summary which becomes a green checkmark or a red x then we should define thresholds to make them a red x on breach. That is more effort than I think it is worth, especially since we already do the same benchmarking in the PR, and this would only add it in the cases where the PR is not rebased before merge.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.