Skip to content

Make workflow not break on merge#242

Merged
sarsko merged 1 commit intomainfrom
workflows
Jan 12, 2026
Merged

Make workflow not break on merge#242
sarsko merged 1 commit intomainfrom
workflows

Conversation

@sarsko
Copy link
Contributor

@sarsko sarsko commented Jan 12, 2026

Currently on merge to main we get the following output for benchmarks:

Run boa-dev/criterion-compare-action@v3
Error: Input required and not supplied: branchName
    at Object.getInput (/home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:1:3790)
    at main (/home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:7:331417)
    at /home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:7:334502
    at /home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:7:334578
    at /home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:7:334582
    at Object.<anonymous> (/home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:7:334621)
    at Module._compile (node:internal/modules/cjs/loader:1521:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1623:10)
    at Module.load (node:internal/modules/cjs/loader:1266:32)
    at Module._load (node:internal/modules/cjs/loader:1091:12)
Error: Unhanded error:
Error: Input required and not supplied: branchName

(ref: https://github.com/awslabs/shuttle/actions/runs/20906721819/job/60061562154)

This PR splits up tests and benchmarking, so that benchmarking is only run in PRs, but not on the merge (while tests are ran for both). This means we shouldn't see the error above.

There is a case to be made for adding benchmarking on merge against the previous HEAD, but the results kind of have nowhere to live; if they live in the job summary which becomes a green checkmark or a red x then we should define thresholds to make them a red x on breach. That is more effort than I think it is worth, especially since we already do the same benchmarking in the PR, and this would only add it in the cases where the PR is not rebased before merge.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sarsko sarsko merged commit d00bba1 into main Jan 12, 2026
7 checks passed
@sarsko sarsko deleted the workflows branch January 22, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant