Update layers.py: remove a mypy: ignore#1117
Open
wyattscarpenter wants to merge 1 commit intoawslabs:mainfrom
Open
Update layers.py: remove a mypy: ignore#1117wyattscarpenter wants to merge 1 commit intoawslabs:mainfrom
wyattscarpenter wants to merge 1 commit intoawslabs:mainfrom
Conversation
`mypy: ignore` is not (yet!) actually a feature of the mypy typechecker. However, once I implemented that feature in [my pull-request](python/mypy#17875), it was reported to me that the `type: ignore` you get here is actually unused anyway! (I guess that makes sense, or yous would have noticed the type error it was supposed to be suppressing get raised anyway.) So, it can just be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypy: ignoreis not (yet!) actually a feature of the mypy typechecker. However, once I implemented that feature in my pull-request, it was reported to me by the tool mypy-primer that themypy: ignorehere is actually unused anyway! (I guess that makes sense, or yous would have noticed the type error, that it was supposed to be suppressing, get raised anyway.) So, it can just be removed.Pull Request Checklist
until you can check this box.
(I have omitted the rest of the checklist items as I suspect they are not applicable to this PR. Sorry if I'm wrong.)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.