Skip to content

import foundationEssentials for the archiver plugin #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

import foundationEssentials for the archiver plugin #403

wants to merge 1 commit into from

Conversation

sebsto
Copy link
Collaborator

@sebsto sebsto commented Oct 10, 2024 •
edited
Loading

working towards the goal of removing import of Foundation
#402

@sebsto sebsto requested a review from fabianfett October 10, 2024 09:14
fabianfett
fabianfett reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foundation will always be present at build time. We don't want to depend on it at runtime.

@sebsto sebsto closed this Oct 10, 2024
@sebsto sebsto deleted the sebsto/plugin-foundation branch October 10, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fabianfett fabianfett fabianfett left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sebsto @fabianfett