Skip to content

Conversation

sebsto
Copy link
Collaborator

@sebsto sebsto commented Dec 19, 2024

added an example showing how to deploy with the CDK
This code is the basis for the upcoming CDK section in the deployment guide

@sebsto sebsto requested a review from 0xTim December 19, 2024 12:49
@sebsto sebsto added the semver/none No version bump required. label Dec 19, 2024
@sebsto sebsto changed the title add CDK deployment example [examples] Add CDK deployment example Dec 19, 2024
Copy link
Contributor

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One query around the manifest

]
)

if let localDepsPath = Context.environment["LAMBDA_USE_LOCAL_DEPS"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all this for the example?

Copy link
Collaborator Author

@sebsto sebsto Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so.

It allows the runtime developers to work on a development version of the runtime and test it with an example.
This is more for the convenience of the runtime developers.

It also allows the CI to run on the synced pair (runtime, examples). Otherwise, examples using the main branch fetch a previous version at CI time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sounds good

@sebsto sebsto enabled auto-merge (squash) December 21, 2024 09:38
@sebsto sebsto disabled auto-merge December 21, 2024 09:39
@sebsto sebsto merged commit 18660fc into awslabs:main Dec 21, 2024
24 checks passed
@sebsto sebsto deleted the sebsto/cdk-example branch December 21, 2024 09:41
sebsto added a commit to sebsto/swift-aws-lambda-runtime that referenced this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants