-
-
Notifications
You must be signed in to change notification settings - Fork 350
Add module for SES v2 #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add module for SES v2 #1356
Conversation
Thanks @rmschots for a PR. Perhaps it could be improved to reduce the duplication, as these classes from V1 and V2 are pretty much the same with small differences. Perhaps both V1 and V2 could live in single module with optional dependencies to SES SDKs, which would allow us to have an abstract base classes for two versions, and then there would be two starters for V1 and V2 that would bring related SDKs? What do you think about it? cc @MatejNedic |
@maciejwalkowiak I implemented the separate module based on the feedback on #1336 (comment). |
@maciejwalkowiak Personally I would prefer duplication since SDK is different. We can slowly than deprecate V1 version much cleaner, specific feature and implementations can be handled much better and so on. I would go with split. Let me take a look in code and think about it, will make a review in following days. |
@MatejNedic Maybe time to look at this one again? It's been a while since it has been forgotten. |
I will take a look in following days. @maciejwalkowiak if all is good we can target it for 4.0.0? |
Since it is a new feature and they broke api I would like to either
Since V2 is not really bringing that much to a table, at least not for our integration, I would go with an option 2. If someone is interested in changes V2 brings-> |
Hey guys, thanks for the amazing work! Really appreciate it. We really need this module. Can you give us a timeline for when this PR will be merged? We really need it 🙏 |
📢 Type of change
📜 Description
Add a module to allow use of SES API v2.
💡 Motivation and Context
Amazon SES API v1 accepts messages up to 10MB in size including any images and attachments that are part of the message. SES API v2 accepts up to 40MB.
Issue #595
Alternative solution to #1336.
This solution guarantees no breaking changes with previous versions, and allows using the v2 API instead.
💚 How did you test it?
📝 Checklist
🔮 Next steps