Skip to content

Conversation

MatejNedic
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it is compatible with #1479 we can merge!

But if we are adding Kinesis integration we can also think about:

Copy link
Contributor

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just couple hygiene nit-picks.
This affects my PR for spring-cloud-aws-kinesis module only at the dependency .
The KPL/KCL could be auto-configured in other PRs.
Thanks

@@ -0,0 +1,28 @@
/*
* Copyright 2013-2022 the original author or authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2013-2025?

@@ -0,0 +1,37 @@
package io.awspring.cloud.autoconfigure.kinesis;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mussed Copyright?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Dependency version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants