-
-
Notifications
You must be signed in to change notification settings - Fork 350
#1457-Introduce-kinesis-autoconfiguration #1483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
#1457-Introduce-kinesis-autoconfiguration #1483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming it is compatible with #1479 we can merge!
But if we are adding Kinesis integration we can also think about:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just couple hygiene nit-picks.
This affects my PR for spring-cloud-aws-kinesis
module only at the dependency .
The KPL/KCL could be auto-configured in other PRs.
Thanks
@@ -0,0 +1,28 @@ | |||
/* | |||
* Copyright 2013-2022 the original author or authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2013-2025
?
@@ -0,0 +1,37 @@ | |||
package io.awspring.cloud.autoconfigure.kinesis; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mussed Copyright?
📢 Type of change
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps