Skip to content

Add some safety checks #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add some safety checks #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Visual_Studio_2017/GraphicalDebugging/ExpressionLoader_UserDefined.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ public Loader Create(Loaders loaders, Debugger debugger, string name, string typ
exprs,
new Geometry.Traits(2, cs, unit));

return simpleGeometry != null
return simpleGeometry != null && simpleGeometry.IsValid == true
? new UserPoint(simpleGeometry)
: null;
}
Expand All @@ -710,7 +710,7 @@ public override Geometry.Traits GetTraits(MemoryReader mreader, Debugger debugge
public override ExpressionDrawer.Point LoadPointParsed(Debugger debugger, string name, string type)
{
UserSimpleGeometryMembers members = simpleGeometry.LoadParsed(debugger, name);
return members != null
return members != null && members.Values != null && members.Values.Length >= 2
? new ExpressionDrawer.Point(members.Values[0], members.Values[1])
: null;
}
Expand All @@ -719,7 +719,7 @@ public override ExpressionDrawer.Point LoadPointMemory(MemoryReader mreader, Deb
string name, string type)
{
UserSimpleGeometryMembers members = simpleGeometry.LoadMemory(mreader, debugger, name);
return members != null
return members != null && members.Values != null && members.Values.Length >= 2
? new ExpressionDrawer.Point(members.Values[0], members.Values[1])
: null;
}
Expand Down