Skip to content

Conversation

@ericzon
Copy link
Collaborator

@ericzon ericzon commented Dec 8, 2022

PR Description

  • Updating minimal requirements to Nodejs v14.21 (LTS) to reduce security issues.
  • Switching node-fetch to esm2cjs/node-fetch due to non CommonJs format on latests node-fetch versions.

Resolves #1196

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericzon
Copy link
Collaborator Author

ericzon commented Dec 8, 2022

It doesn't seem to be resolving properly it's internal dependencies when tests run :(

Error appearing:

    Cannot find module '@esm2cjs/fetch-blob/file.js' from 'packages/directline-connector/node_modules/@esm2cjs/formdata-polyfill/cjs/index.js'

Instead of @esm2cjs/fetch-blob/file.js should be looking at @esm2cjs/fetch-blob/cjs/file.js

image

@ericzon ericzon changed the title change: from node-fetch to esj2cjs/node-fetch change: from node-fetch to esm2cjs/node-fetch Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants