Open
Conversation
commit: |
2fca7f1 to
6c2b10c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #283.
Summary
axiom evalinstead of always exiting 0 on the normal non-watch pathdangerouslyIgnoreUnhandledErrorsso ignored unhandled errors do not force a failing exit codeNew behavior
axiom evalnow exits with a nonzero status when eval suites fail on the normal non-watch path, matching CI expectations. If a project enables Vitest'sdangerouslyIgnoreUnhandledErrors, ignored unhandled errors continue to be non-fatal.Validation
pnpm --filter axiom exec vitest run test/evals/run-vitest.test.tspnpm --filter axiom typecheckpnpm --filter axiom test -- run test/evals/run-vitest.test.tsNote
Medium Risk
Changes the CLI/evals runner process exit behavior, which can affect CI outcomes and downstream scripts; failure detection now depends on Vitest result fields and config flags.
Overview
axiom evalnow propagates Vitest execution failures via its exit code on the normal non-watch path instead of always exiting0.Failure detection is centralized in
hasVitestFailures, covering failed test counts, failed/invalid modules, and unhandled errors while respecting Vitest’sdangerouslyIgnoreUnhandledErrors.Adds a dedicated
run-vitest.test.tssuite to regression-test exit codes across success, failed tests/modules, unhandled/ignored errors, list mode (no execution), and validation abort handling.Written by Cursor Bugbot for commit 6c2b10c. This will update automatically on new commits. Configure here.