[WASM] Fix Downloader storage issue, new options for wasm #3049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halx99
reviewed
Jan 24, 2026
| # --preload-file | ||
| # refer to: https://emscripten.org/docs/porting/files/packaging_files.html | ||
| set(_WASM_ASSETS_LINKER_FILE "--preload-file") | ||
| endif() |
Collaborator
There was a problem hiding this comment.
Better logic:
if(AX_WASM_ASSETS_PRELOAD_FILE)
# --preload-file
# refer to: https://emscripten.org/docs/porting/files/packaging_files.html
set(_WASM_ASSETS_LINKER_FILE "--preload-file")
else()
set(_WASM_ASSETS_LINKER_FILE "--embed-file")
endif()
Contributor
Author
There was a problem hiding this comment.
We could do this only once below the option(..)
halx99
approved these changes
Jan 25, 2026
Contributor
Author
|
I didn't make the changes yet 😅 |
Collaborator
|
it works as excepted, so merge is ok |
halx99
added a commit
that referenced
this pull request
Jan 25, 2026
1. **AX_WASM_ASSETS_PRELOAD_FILE** (default: ON) - When enabled, bundles assets into a .data file and preloads them into IndexedDB cache on first launch (using `--preload-file`) - When disabled, embeds assets directly into the wasm file (using `--embed-file`) without IndexedDB usage - Provides flexibility for different deployment scenarios 2. **AX_WASM_GENERATE_SYMBOL_FILE** (default: OFF) - Enables generation of a symbol file for the built wasm, aiding in debugging and profiling Additionally: - Refactored WASM-related CMake configuration into a consolidated section - Removed `EMSCRIPTEN_FETCH_PERSIST_FILE` from Downloader-wasm.cpp to prevent unnecessary file persistence - Updated documentation in CMakeOptions.md with the new options - Unified asset linking flags to use the configurable `AX_WASM_ASSETS_LINKER_FLAG` Refer: #3049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix the wasm storage issue described in #3040 by removing
EMSCRIPTEN_FETCH_PERSIST_FILEand only use memory.Add 2 new options for WASM:
AX_WASM_ASSETS_PRELOAD_FILE: Whether enable to bundle the assets to a .data file and preload them into an IndexedDB cache at first launch (--preload-file), otherwise bundle them into the wasm file itself and don't use the IndexedDB at all (--embed-file)", defaultTRUEAX_WASM_GENERATE_SYMBOL_FILE: Generate a symbol file for the built wasm file, defaultFALSE