Skip to content

Fix assertion failure when converting empty subrange to std::string_view#3080

Merged
halx99 merged 1 commit intodevfrom
fix-subrgn-to-sv
Mar 6, 2026
Merged

Fix assertion failure when converting empty subrange to std::string_view#3080
halx99 merged 1 commit intodevfrom
fix-subrgn-to-sv

Conversation

@halx99
Copy link
Collaborator

@halx99 halx99 commented Mar 5, 2026

Describe your changes

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

@halx99 halx99 added this to the 3.0.0 milestone Mar 5, 2026
@halx99 halx99 added the bug Something isn't working label Mar 5, 2026
@aismann aismann self-requested a review March 5, 2026 15:27
@aismann
Copy link
Contributor

aismann commented Mar 5, 2026

Tested on PR #3076
50:UI test => 21:RichText Test => 19 ... works as expected.

@halx99 halx99 merged commit ce58ea9 into dev Mar 6, 2026
26 checks passed
@halx99 halx99 deleted the fix-subrgn-to-sv branch March 6, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants