Fix retrieving model for reverse relations#573
Open
glowka wants to merge 22 commits intoaxnsan12:masterfrom
Open
Fix retrieving model for reverse relations#573glowka wants to merge 22 commits intoaxnsan12:masterfrom
glowka wants to merge 22 commits intoaxnsan12:masterfrom
Conversation
0eacfc9 to
6814a67
Compare
6814a67 to
da5f800
Compare
fix map source mapping
[readme] Fix missing re_path import
Add utf-8 support for generated formats
Remove universal wheel, python 2 is unsupported
Fix old spelling errors and add a cspell configuration.
…-arbitrary-references Allow specifying response as a reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
current util
get_related_modelimplementation does not take into account that reverse relations (descriptor can be both forward and reverse) so for reverse relations it leads to bugs like this:New implementation robustly checks type of relation and returns appropriate model.
It supports all kind of descriptors:
OneToOne,ManyToOne,ManyToMany.