Skip to content

Fix: Resolve torch_dtype correctly for AMP #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −2
Open

Fix: Resolve torch_dtype correctly for AMP #3189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fcad33
Fix: Resolve torch_dtype correctly for AMP
onesnep Sep 26, 2025
d403a2b
chore: lint
winglian Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/axolotl/utils/config/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,12 @@ def resolve_dtype(cfg):
if cfg.bf16:
cfg.fp16 = False

if cfg.bf16 or cfg.bfloat16:
# For mixed precision, we want the base model loaded in fp32
if cfg.fp16 or cfg.bf16:
cfg.torch_dtype = torch.float32
elif cfg.bfloat16:
cfg.torch_dtype = torch.bfloat16
elif cfg.load_in_8bit or cfg.fp16 or cfg.float16:
elif cfg.load_in_8bit or cfg.float16:
cfg.torch_dtype = torch.float16
else:
cfg.torch_dtype = torch.float32
Expand Down
Loading