Skip to content

check ubuntu user and set uv python dir#3492

Merged
winglian merged 1 commit intomainfrom
uv-path-non-root
Mar 13, 2026
Merged

check ubuntu user and set uv python dir#3492
winglian merged 1 commit intomainfrom
uv-path-non-root

Conversation

@winglian
Copy link
Collaborator

@winglian winglian commented Mar 13, 2026

Summary by CodeRabbit

  • Chores
    • Improved Docker container reliability with enhanced user setup and system permissions configuration.
    • Optimized Python installation environment configuration for better system compatibility.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2dd21b5b-224b-42c2-b5e5-05d0ca2e36e4

📥 Commits

Reviewing files that changed from the base of the PR and between 79908b3 and e4a471e.

📒 Files selected for processing (2)
  • docker/Dockerfile-uv
  • docker/Dockerfile-uv-base

📝 Walkthrough

Walkthrough

Two Dockerfile configurations were modified to enhance user and environment setup. Dockerfile-uv now includes conditional logic to create an ubuntu user with passwordless sudo access if it doesn't exist. Dockerfile-uv-base adds an environment variable for the UV Python installation directory and adjusts file permissions on the installation path.

Changes

Cohort / File(s) Summary
Ubuntu User Configuration
docker/Dockerfile-uv
Adds conditional logic to create the ubuntu user with home directory and login shell if not present, installs sudo, configures passwordless sudoers entry, and adjusts ownership before switching user context.
UV Python Installation Setup
docker/Dockerfile-uv-base
Introduces UV_PYTHON_INSTALL_DIR environment variable set to "/opt/uv/python" and extends the Python installation step to recursively grant read/execute permissions on the installation directory.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch uv-path-non-root
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@winglian winglian merged commit 083c5a0 into main Mar 13, 2026
0 of 18 checks passed
@winglian winglian deleted the uv-path-non-root branch March 13, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant