refactor: use telescope/fzf-lua to replace glance.nvim#1519
Open
refactor: use telescope/fzf-lua to replace glance.nvim#1519
Conversation
ayamir
requested review from
Jint-lzxy and
charliie-dev
and removed request for
Jint-lzxy
ayamir
force-pushed
the
chore/remove-glance
branch
from
2739a77 to
b1d4868
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr removed
glance.nvim. Reason:glance.nvimjust has vscode like ui, but it's inconvinent for lots of results. Usetelescope/fzf-luais more suitable b/c it can search result.glance.nvimusevto vsplit, buttelescope/fzf-luause<C-v>.Besides, this pr use
Lspsaga peek_definitionto preview definition, which will change the keymap to jump to definition in the preview buf (Now is<C-o>), but the spilt-related keymap is consistent withtelescope/fzf(<C-v>/<C-x>)