Skip to content

Comments

Fallback to Google DNS in resolver initialization#315

Merged
mat-1 merged 2 commits intoazalea-rs:mainfrom
thesalam4ik:dns-resolver-fix
Feb 4, 2026
Merged

Fallback to Google DNS in resolver initialization#315
mat-1 merged 2 commits intoazalea-rs:mainfrom
thesalam4ik:dns-resolver-fix

Conversation

@thesalam4ik
Copy link
Contributor

If the default TokioResolver builder fails, the resolver now falls back to using Google's DNS configuration. This improves reliability in environments where the system DNS configuration may be unavailable or invalid.

If the default TokioResolver builder fails, the resolver now falls back to using Google's DNS configuration. This improves reliability in environments where the system DNS configuration may be unavailable or invalid.
Copy link
Collaborator

@mat-1 mat-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This seems fine, but it should log a warning (with the warn! macro) with the error so the user has some feedback if they did expect it to use their system resolver.

A tracing warning is now logged if the system DNS resolver is unavailable and the resolver falls back to using Google DNS. This improves visibility into resolver configuration issues.
@thesalam4ik
Copy link
Contributor Author

Done

Thanks for the PR! This seems fine, but it should log a warning (with the warn! macro) with the error so the user has some feedback if they did expect it to use their system resolver.

@thesalam4ik thesalam4ik requested a review from mat-1 February 2, 2026 12:23
Copy link
Collaborator

@mat-1 mat-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@mat-1 mat-1 merged commit 4bf8247 into azalea-rs:main Feb 4, 2026
@thesalam4ik thesalam4ik deleted the dns-resolver-fix branch February 4, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants