Merge pull request ClickHouse#79220 from ClickHouse/pg-osx

fix build on osx with command line tool 16.3

Author: azat

cmake/darwin/default_libs.cmake

@@ -15,5 +15,18 @@ set(CMAKE_OSX_DEPLOYMENT_TARGET 10.15)
 set(THREADS_PREFER_PTHREAD_FLAG ON)
 find_package(Threads REQUIRED)
 
+if(NOT CMAKE_CROSSCOMPILING)
+    execute_process(
+        COMMAND xcrun --sdk macosx --show-sdk-version
+        OUTPUT_VARIABLE OS_DARWIN_SDK_VERSION
+        OUTPUT_STRIP_TRAILING_WHITESPACE
+    )
+    if(${OS_DARWIN_SDK_VERSION} MATCHES "^[0-9]+\\.[0-9]+")
+        message(STATUS "Detected OSX SDK Version: ${OS_DARWIN_SDK_VERSION}")
+    else ()
+        message(WARNING "Unexpected OSX SDK Version: ${OS_DARWIN_SDK_VERSION}")
+    endif()
+endif()
+
 include (cmake/unwind.cmake)
-include (cmake/cxx.cmake)
+include (cmake/cxx.cmake)

contrib/postgres-cmake/CMakeLists.txt

@@ -79,6 +79,13 @@ if (OS_DARWIN OR OS_FREEBSD OR USE_MUSL)
     target_compile_definitions(_libpq PRIVATE -DSTRERROR_R_INT=1)
 endif()
 
+# Mac 15.4 / Xcode 16.3 started defining srtchrnul
+# Could be cleaned up if properly resolved in upstream
+# https://www.postgresql.org/message-id/flat/385134.1743523038%40sss.pgh.pa.us
+if (OS_DARWIN AND OS_DARWIN_SDK_VERSION AND OS_DARWIN_SDK_VERSION VERSION_GREATER_EQUAL 15.4)
+    target_compile_definitions(_libpq PRIVATE -DHAVE_STRCHRNUL)
+endif()
+
 target_link_libraries (_libpq PRIVATE OpenSSL::SSL)
 
 add_library(ch_contrib::libpq ALIAS _libpq)