Merge pull request ClickHouse#79941 from hanfei1991/hanfei/hide-secret-datalake-catalog

hide credentails for datalake catalog

Author: hanfei1991

src/Parsers/FunctionSecretArgumentsFinder.h

@@ -628,6 +628,10 @@ class FunctionSecretArgumentsFinder
             /// S3('url', 'access_key_id', 'secret_access_key')
             findS3DatabaseSecretArguments();
         }
+        else if (engine_name == "DataLakeCatalog")
+        {
+            findDataLakeCatalogSecretArguments();
+        }
     }
 
     void findMySQLDatabaseSecretArguments()
@@ -658,6 +662,14 @@ class FunctionSecretArgumentsFinder
         }
     }
 
+    void findDataLakeCatalogSecretArguments()
+    {
+        /// datalake catalog should support different storage types,
+        /// we need a function to check if the url is S3 or Azure.
+        /// right now we assume it's a S3 url
+        findS3DatabaseSecretArguments();
+    }
+
     void findBackupNameSecretArguments()
     {
         const String & engine_name = function->name();

tests/integration/test_database_iceberg/test.py

@@ -138,6 +138,9 @@ def create_clickhouse_iceberg_database(
 SETTINGS {",".join((k+"="+repr(v) for k, v in settings.items()))}
     """
     )
+    show_result = node.query(f"SHOW DATABASE {name}")
+    assert minio_secret_key not in show_result
+    assert "HIDDEN" in show_result
 
 
 def print_objects():