Skip to content

Commit 25e5be8

Browse files
committed
better code
1 parent 187d497 commit 25e5be8

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

src/Parsers/FunctionSecretArgumentsFinder.h

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,11 +623,15 @@ class FunctionSecretArgumentsFinder
623623
/// PostgreSQL('host:port', 'database', 'user', 'password')
624624
findMySQLDatabaseSecretArguments();
625625
}
626-
else if (engine_name == "S3" || engine_name == "DataLakeCatalog")
626+
else if (engine_name == "S3")
627627
{
628628
/// S3('url', 'access_key_id', 'secret_access_key')
629629
findS3DatabaseSecretArguments();
630630
}
631+
else if (engine_name == "DataLakeCatalog")
632+
{
633+
findDataLakeCatalogSecretArguments();
634+
}
631635
}
632636

633637
void findMySQLDatabaseSecretArguments()
@@ -658,6 +662,14 @@ class FunctionSecretArgumentsFinder
658662
}
659663
}
660664

665+
void findDataLakeCatalogSecretArguments()
666+
{
667+
/// datalake catalog should support different storage types,
668+
/// we need a function to check if the url is S3 or Azure.
669+
/// right now we assume it's a S3 url
670+
findS3DatabaseSecretArguments();
671+
}
672+
661673
void findBackupNameSecretArguments()
662674
{
663675
const String & engine_name = function->name();

0 commit comments

Comments
 (0)