Merge pull request ClickHouse#80088 from shankar-iyer/disable_enble_url_encoding

Default of enable_url_encoding set to 0

Author: shankar-iyer

base/poco/Foundation/src/URI.cpp

@@ -690,7 +690,7 @@ void URI::encodePath(std::string & encodedStr) const
     if (_enable_url_encoding)
         encode(_path, RESERVED_PATH, encodedStr);
     else
-        encodedStr = _path;
+        encodedStr = encodedStr + _path;
 }
 
 void URI::decodePath(const std::string & encodedStr)

src/Core/Settings.cpp

@@ -5041,10 +5041,10 @@ Possible values:
 - 0 — `SELECT` throws an exception if empty file is not compatible with requested format.
 - 1 — `SELECT` returns empty result for empty file.
 )", 0) \
-    DECLARE(Bool, enable_url_encoding, true, R"(
+    DECLARE(Bool, enable_url_encoding, false, R"(
 Allows to enable/disable decoding/encoding path in uri in [URL](../../engines/table-engines/special/url.md) engine tables.
 
-Enabled by default.
+Disabled by default.
 )", 0) \
     DECLARE(UInt64, database_replicated_initial_query_timeout_sec, 300, R"(
 Sets how long initial DDL query should wait for Replicated database to process previous DDL queue entries in seconds.

src/Core/SettingsChangesHistory.cpp

@@ -106,6 +106,7 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
             {"use_legacy_to_time", false, false, "New setting. Allows for user to use the old function logic for toTime, which works as toTimeWithFixedDate."},
             {"input_format_parquet_bloom_filter_push_down", false, true, "When reading Parquet files, skip whole row groups based on the WHERE/PREWHERE expressions and bloom filter in the Parquet metadata."},
             {"input_format_parquet_allow_geoparquet_parser", false, true, "A new setting to use geo columns in parquet file"},
+            {"enable_url_encoding", true, false, "Changed existing setting's default value"},
             {"s3_slow_all_threads_after_network_error", false, true, "New setting"},
         });
         addSettingsChanges(settings_changes_history, "25.4",