Skip to content

Commit 6a48dab

Browse files
committed
removed unnecessary comments
1 parent d5d2a08 commit 6a48dab

File tree

2 files changed

+2
-37
lines changed

2 files changed

+2
-37
lines changed

src/Common/AddressToLineCache.cpp

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -2,47 +2,12 @@
22
#include <Common/AddressToLineCache.h>
33
#include <Common/SymbolIndex.h>
44
#include <IO/WriteHelpers.h>
5-
//#include <Core/Field.h>
6-
//#include <base/demangle.h>
75

86
#include <filesystem>
97

108
namespace DB
119
{
1210

13-
//std::pair<Array, Array> generateArraysSymbolsLines(std::vector<UInt64> trace)
14-
//{
15-
// Array symbols;
16-
// Array lines;
17-
// size_t num_frames = trace.size();
18-
// symbols.reserve(num_frames);
19-
// lines.reserve(num_frames);
20-
//
21-
// const SymbolIndex & symbol_index = SymbolIndex::instance();
22-
//
23-
// for (size_t frame = 0; frame < num_frames; ++frame)
24-
// {
25-
// if (const auto * symbol = symbol_index.findSymbol(reinterpret_cast<const void *>(trace[frame])))
26-
// {
27-
// std::string_view mangled_symbol(symbol->name);
28-
//
29-
// auto demangled = tryDemangle(symbol->name);
30-
// if (demangled)
31-
// symbols.emplace_back(std::string_view(demangled.get()));
32-
// else
33-
// symbols.emplace_back(std::string_view(symbol->name));
34-
//
35-
// lines.emplace_back(AddressToLineCache::get(trace[frame]).toView());
36-
// }
37-
// else
38-
// {
39-
// symbols.emplace_back(String());
40-
// lines.emplace_back(String());
41-
// }
42-
// }
43-
//
44-
// return {symbols, lines};
45-
//}
4611

4712
void AddressToLineCache::setResult(StringRef & result, const Dwarf::LocationInfo & location, const std::vector<Dwarf::SymbolizedFrame> &)
4813
{

src/Common/SymbolIndex.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#include <base/defines.h>
2-
//#if defined(__ELF__) && !defined(OS_FREEBSD)
2+
#if defined(__ELF__) && !defined(OS_FREEBSD)
33

44
#include <base/MemorySanitizer.h>
55
#include <base/hex.h>
@@ -534,4 +534,4 @@ const SymbolIndex & SymbolIndex::instance()
534534

535535
}
536536

537-
//#endif
537+
#endif

0 commit comments

Comments
 (0)