fixed tests

Author: Dolso

src/Interpreters/ErrorLog.cpp

@@ -119,8 +119,8 @@ void ErrorLogElement::appendToBlock(MutableColumns & columns) const
 
     std::vector<UInt64> error_trace_array;
     error_trace_array.reserve(error_trace.size());
-    for (size_t i = 0; i < error_trace.size(); ++i)
-        error_trace_array.emplace_back(reinterpret_cast<UInt64>(error_trace[i]));
+    for (auto * ptr : error_trace)
+        error_trace_array.emplace_back(reinterpret_cast<UInt64>(ptr));
 
     columns[column_idx++]->insert(Array(error_trace_array.begin(), error_trace_array.end()));
 

src/Interpreters/SystemLog.cpp

@@ -14,7 +14,6 @@
 #include <Interpreters/Context.h>
 #include <Interpreters/CrashLog.h>
 #include <Interpreters/DatabaseCatalog.h>
-#include <Interpreters/ErrorLog.h>
 #include <Interpreters/FilesystemCacheLog.h>
 #include <Interpreters/FilesystemReadPrefetchesLog.h>
 #include <Interpreters/InterpreterCreateQuery.h>

tests/queries/0_stateless/02117_show_create_table_system.reference

@@ -265,7 +265,9 @@ CREATE TABLE system.errors
     `last_error_message` String,
     `last_error_trace` Array(UInt64),
     `remote` UInt8,
-    `query_id` String
+    `last_error_query_id` String,
+    `last_error_symbols` Array(LowCardinality(String)),
+    `last_error_lines` Array(LowCardinality(String))
 )
 ENGINE = SystemErrors
 COMMENT 'Contains a list of all errors which have ever happened including the error code, last time and message with unsymbolized stacktrace.'

tests/queries/0_stateless/03361_system_errors_query_id.sh

@@ -10,7 +10,7 @@ $CLICKHOUSE_CLIENT --query_id="$query_id" -q "select query_id" &>/dev/null
 
 retry=0
 max_retries=30
-while [[ $($CLICKHOUSE_CLIENT -q "SELECT count(*) FROM system.errors WHERE query_id = '$query_id' and code = 47") -lt 1 ]]; do
+while [[ $($CLICKHOUSE_CLIENT -q "SELECT count(*) FROM system.errors WHERE last_error_query_id = '$query_id' and code = 47") -lt 1 ]]; do
   retry=$((retry+1))
 
   if [ $retry -ge $max_retries ]; then