Conversation
frol
left a comment
frol
left a comment
There was a problem hiding this comment.
I have a couple of quick comments/questions
|
|
||
| "permissions": { | ||
| "storage": true, | ||
| "location": true, |
There was a problem hiding this comment.
Why is location access is needed? I am mostly just curious, not a blocker for me
There was a problem hiding this comment.
We use window.selector.location to show it in the UI.
repository/manifest.json
Outdated
| "permissions": { | ||
| "storage": true, | ||
| "location": true, | ||
| "allowsOpen": ["https://nearmobile.app", "https://play.google.com", "https://apps.apple.com"] |
There was a problem hiding this comment.
In my testing the old version on the mobile devices, I realized that this list needs to be extended with "https://near-mobile-signer-backend.peersyst.tech" as it was used to open the mobile app when clicking on "Sign transaction". Have you tested your new plugin to work on the mobile devices?
There was a problem hiding this comment.
You're right! In the new version we use https://near-mobile-production.aws.peersyst.tech. Updated!
There was a problem hiding this comment.
Since you only removed NEAR Mobile, I wonder whether these changes are needed. Can you comment on pros/cons of these?
There was a problem hiding this comment.
It solves this issue #63. I forgot to link it, my bad!
| "@types/node": "^24.9.1", | ||
| "@walletconnect/modal": "^2.7.0", | ||
| "borsh": "^2.0.0", | ||
| "near-api-js": "^4.0.0", |
There was a problem hiding this comment.
It wasn't here before, and it seemed to work fine. Was it just a coincidence that near-api-js was just inherited from @peersyst/near-mobile-signer?
There was a problem hiding this comment.
It was being installed by @peersyst/near-mobile-signer but was also being used by other wallets.
|
@AgustinMJ There are multiple bugs that I noticed over the current implementation:
Please, make sure you at least test all the buttons on the Example app ( |
2 participants
Fixes sign in with near mobile and improves implementation.
Closes #63