Skip to content

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Sep 6, 2021

Copy link
Collaborator

@AdrieanKhisbe AdrieanKhisbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelDeBoey feels like a duplicate of #69. (mentioned in #68)

Am I wrong?

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #70 (2de4b36) into master (a677b11) will decrease coverage by 17.64%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##            master      #70       +/-   ##
============================================
- Coverage   100.00%   82.35%   -17.65%     
============================================
  Files            1        1               
  Lines           51       51               
============================================
- Hits            51       42        -9     
- Misses           0        9        +9     
Impacted Files Coverage Δ
src/index.js 82.35% <0.00%> (-17.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a677b11...2de4b36. Read the comment docs.

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Sep 6, 2021

@AdrieanKhisbe Oh sorry, I didn't see that one 😕

This PR is adding some small fixes and updates ESLint dependency of the package too though.

@AdrieanKhisbe
Copy link
Collaborator

@MichaelDeBoey, no problem. I just closed #69 as yours is more complete

Since we use `npm test` in CI and use a separate command for integration
tests, we need to make sure `npm test` runs the unit tests.
@azeemba
Copy link
Owner

azeemba commented Oct 10, 2021

Thanks for the PR!

Since there are no code changes, I am not planning on publishing a new release. Let me know if there are any concerns with that plan!

@azeemba azeemba merged commit d4064d8 into azeemba:master Oct 10, 2021
@MichaelDeBoey MichaelDeBoey deleted the eslint-8 branch October 10, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x
4 participants