Skip to content

Commit 2e6b1e6

Browse files
committed
wip
1 parent ca1288d commit 2e6b1e6

File tree

3 files changed

+6
-16
lines changed

3 files changed

+6
-16
lines changed

HelloVulkan/Header/UBOs.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,11 @@ struct ShadowMapUBO
3737
alignas(4)
3838
float shadowMaxBias;
3939
alignas(4)
40-
float shadowNearPlane;
40+
float cameraNearPlane;
4141
alignas(4)
42-
float shadowFarPlane;
42+
float cameraFarPlane;
4343
alignas(4)
4444
float pcfScale;
45-
alignas(4)
46-
uint32_t pcfIteration;
4745
};
4846

4947
// Per model transformation matrix

HelloVulkan/Source/Apps/AppPBRShadow.cpp

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -171,12 +171,11 @@ void AppPBRShadow::UpdateUI()
171171
{
172172
.shadowMinBias = 0.001f,
173173
.shadowMaxBias = 0.001f,
174-
.shadowNearPlane = 10.0f,
175-
.shadowFarPlane = 40.0f,
174+
.cameraNearPlane = CameraConfig::Near,
175+
.cameraFarPlane = CameraConfig::Far,
176176
.pcfScale = 0.5f
177177
};
178178
static float staticLightPos[3] = { -5.f, 30.0f, 5.0f};
179-
static int staticPCFIteration = 2;
180179

181180
imguiPtr_->ImGuiStart();
182181
imguiPtr_->ImGuiSetWindow("Bindless Shadow Mapping", 525, 650);
@@ -190,10 +189,7 @@ void AppPBRShadow::UpdateUI()
190189
ImGui::SeparatorText("Shadow mapping");
191190
ImGui::SliderFloat("Min Bias", &staticShadowUBO.shadowMinBias, 0.00001f, 0.01f);
192191
ImGui::SliderFloat("Max Bias", &staticShadowUBO.shadowMaxBias, 0.001f, 0.1f);
193-
ImGui::SliderFloat("Near Plane", &staticShadowUBO.shadowNearPlane, 0.1f, 50.0f);
194-
ImGui::SliderFloat("Far Plane", &staticShadowUBO.shadowFarPlane, 10.0f, 150.0f);
195192
ImGui::SliderFloat("PCF Scale", &staticShadowUBO.pcfScale, 0.1f, 3.0f);
196-
ImGui::SliderInt("PCF Iteration", &staticPCFIteration, 1, 10);
197193

198194
ImGui::SeparatorText("Light position");
199195
ImGui::SliderFloat("X", &(staticLightPos[0]), -10.0f, 10.0f);
@@ -210,10 +206,7 @@ void AppPBRShadow::UpdateUI()
210206

211207
shadowUBO_.shadowMinBias = staticShadowUBO.shadowMinBias;
212208
shadowUBO_.shadowMaxBias = staticShadowUBO.shadowMaxBias;
213-
shadowUBO_.shadowNearPlane = staticShadowUBO.shadowNearPlane;
214-
shadowUBO_.shadowFarPlane = staticShadowUBO.shadowFarPlane;
215209
shadowUBO_.pcfScale = staticShadowUBO.pcfScale;
216-
shadowUBO_.pcfIteration = staticPCFIteration;
217210
}
218211

219212
// This is called from main.cpp

Shaders/ShadowMapping/UBO.glsl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ struct ShadowUBO
88
vec4 lightPosition;
99
float shadowMinBias;
1010
float shadowMaxBias;
11-
float shadowNearPlane;
12-
float shadowFarPlane;
11+
float cameraNear;
12+
float cameraFar;
1313
float pcfScale;
14-
uint pcfIteration;
1514
};

0 commit comments

Comments
 (0)